Completed
Pull Request — master (#234)
by
unknown
41s
created

formManager.constructor   B

Complexity

Conditions 1
Paths 288

Size

Total Lines 186

Duplication

Lines 0
Ratio 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
cc 1
c 2
b 0
f 0
nc 288
nop 0
dl 0
loc 186
rs 7.1707

1 Function

Rating   Name   Duplication   Size   Complexity  
A findForm.js ➔ ... ➔ document.forEach 0 1 1

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
function fillPassword(user, password) {
2
    if(user){
3
        document.querySelectorAll('input[type=text], input[type=email]').forEach(function(x){x.value=user;});
4
    }
5
    if(password) {
6
        document.querySelectorAll('input[type=password]').forEach(function(x){ x.value=password;});
7
    }
8
}
9